Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute 2021 03 API release #14121

Closed
wants to merge 36 commits into from
Closed

Compute 2021 03 API release #14121

wants to merge 36 commits into from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Apr 26, 2021

Update: moved to this PR for the required commit history format: #14223

This PR is to release the new version of Compute, 2021-03-01.

This release consists of these PR, all of which have been reviewed before:

  1. Deep Deletion: Support for Deep Deletion of disks #13657
  2. Scheduled Events: Scheduled Events on VM Property #13351
  3. PatchSetting Assessment mode: Add OSProfile.WindowsConfiguration.PatchSettings.assessmentMode + Lin… #13468
  4. Network Interface Config :Add network interface configuration schema for virtual machine network profile #13449 (Required and received ARM signoff)
  5. Patchsetting Description : Update description for patchSettings property to include VMSS Flex #13509
  6. RestorePoint: Add RestorePoints in stable 2021-03-01 #13219 (Required and received ARM signoff)
  7. UserData: Add UserData properties for VM and VMSS for stable 2021-03-01 #13220
  8. update comments for UserData #14191
  9. Fixing broken links/ updating some sentences #14197

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Sandido and others added 24 commits February 26, 2021 17:04
…ate (#12442)

* add new api version 2020-09-30 for gallery.json

* add support for api change, sharing profile related

* update, change post to patch

* fix model validation error

* fix typo

* add shared gallery api

* update

* fix typo

* update

* update

* update

* chagne new api version to preview

* update readme.md and nit

* remove some required field and make groups readonly

* add swagger support for Grace's and Tim's work

* error fix

* error fix

* change api version name to 2020-09-30 withour 'preview'

* update

* fix typo

* address pr comment

* set modelAsString to true for gallery sharing-related enum

* update, fix merge

* remove duplicate entry

* shared gallery, change id to identifier.uniqueId

* fix typo

* update, remove x-ms-azure-resource for shared gallery

* change name of Permissions to avoid SDK code build error

* update

* add new line

* move all 2020-09-30 shared gallery api version to stable

* update blob as source template and example

* add example that user can update sig image without source id

* update get sig version with vhd source

* update readme.md

* update files after prettier check

* update azureresourceschema.md

* update typo

* resolve breaking change

* address comments

* include gallery example change

* add stable/2020-09-30/gallery and sharedGallery to readme file

* nit

* address comment
…ate (#12442)

* add new api version 2020-09-30 for gallery.json

* add support for api change, sharing profile related

* update, change post to patch

* fix model validation error

* fix typo

* add shared gallery api

* update

* fix typo

* update

* update

* update

* chagne new api version to preview

* update readme.md and nit

* remove some required field and make groups readonly

* add swagger support for Grace's and Tim's work

* error fix

* error fix

* change api version name to 2020-09-30 withour 'preview'

* update

* fix typo

* address pr comment

* set modelAsString to true for gallery sharing-related enum

* update, fix merge

* remove duplicate entry

* shared gallery, change id to identifier.uniqueId

* fix typo

* update, remove x-ms-azure-resource for shared gallery

* change name of Permissions to avoid SDK code build error

* update

* add new line

* move all 2020-09-30 shared gallery api version to stable

* update blob as source template and example

* add example that user can update sig image without source id

* update get sig version with vhd source

* update readme.md

* update files after prettier check

* update azureresourceschema.md

* update typo

* resolve breaking change

* address comments

* include gallery example change

* add stable/2020-09-30/gallery and sharedGallery to readme file

* nit

* address comment
sync changes merged to 2020-12 compute.json to 2021-03.
* Add event schemas for Microsoft.PolicyInsights (#13590)

* Add event schemas for Microsoft.PolicyInsights

* Fix bad indentation

* Specify the datetime format used by timestamp.

* Use format: "date-time" to enable automatic parsing by the SDK

* Pprp (#13661)

* Update to use common type

* Change to use common types.

* Change to use common types.

* Change to use common types.

* Change to use common types.

* Change to use common types.

* Update to use common type.

* Update .gitignore

* Update .gitignore

* Revert "Update to use common type."

This reverts commit ad02e0631776f2e016300a02c56ab0bd85f4c97c.

* Delete .gitignore

* Updating the models.

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Use common types

* Updates for network injection.

* Updates for network injection.

* Updates for network injection.

* Updates for network injection.

* Updates for network injection.

* Updates for network injection.

* Enterprise Policies update

* Support Inplace phase 2 API's for AzureDataShare (#13647)

Co-authored-by: Aditya Vutukuri <advutuku@microsoft.com>

* Communication cli directive config checkin (#13770)

* communication-cli-directive-config-checkin

* typo

* typo

* fixing the URL for Authorization (#13767)

* [NetAppFiles] Fix protocolType example (#13729)

* Fix protocolType example

* Pretty

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2021-03-03-preview (#13256)

* Adds base for updating Microsoft.AppPlatform from version preview/2020-11-01-preview to version 2021-03-03-preview

* Updates readme

* Updates API version in new specs and examples

* add ResourceRequest property in deploymentsettings

* fix typo

* fix typo

* add descriptions for field resourceRequests

* Adding space between Identities in Enum (#13561)

* Updated the models to include systemData and removed the supression f… (#13354)

* Updated the models to include systemData and removed the supression for systemData

* removed the deleted account examples and the package-lock.json

* ran prettier locally to try and fix prettier validation error when making a PR

* removing unecessary changes from last commit

* Revert "removed the deleted account examples and the package-lock.json"

This reverts commit 9a0b368a7aad1fc43460b329fcb4de32c1670606.

* Revert "ran prettier locally to try and fix prettier validation error when making a PR"

This reverts commit 3f11b97fdeef719f622120ba68e5d9cf68d89102.

* Revert "ran prettier locally to try and fix prettier validation error when making a PR"

This reverts commit 3f11b97fdeef719f622120ba68e5d9cf68d89102.

* reverted the package-lock.json and .vscode/launch.json

* reverted older commit

* Removed unecessary files

This reverts commit 708bc8700c8a13c408a232903e14cae57fd136ee.

* Revert "Removed unecessary files"

This reverts commit a27ce012bf115a486d87d6d2b1d7e8416f6473a3.

* Removed deleted account examples and package-lock.json

* Ran prettier to format the json files

Co-authored-by: Melvin Bosnjak <mbosnjak@microsoft.com>

* t2 synapse readme config (#13790)

* update OperationalInsights package for SDK release  (#13782)

* added3 new properties to TableProperties:
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.

* added Tables new api version

* changed bool to boolean types

* prettified jsons

* fix erroes in swagger

* undo changes to 2020-03-01-preview version

* pr fixes

* updated TableUpdate example

* changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example

* changed v1 to v2

* changed WorkspaceNameParameter back to V1

* changed ErrorResponse to default ErrorResponse without ref to local definition

* added systemData

* removed systemData

* added systemData to Patch and Get

* moved systemData to Table properties

* deleted systemData from Table.json, added to Get and Put examles

* changed location of systemData in Tables.json

* moved systemData to inside Table definition

* moved systemData inside Table properties

* removed SystemData

* creatted a new package containing all latest swagger files for publishing new SDK

* removed package 2021_02 and set default packate to 2020_10

* removed 2 packages

* removed DataCollectorLogs.json from readme.md 20202.10

* added empty line to try invoke pipeline validations that havent run

* Delete Tables.json

* added3 new properties to TableProperties:
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.

* merge

* prettified jsons

* undo changes to 2020-03-01-preview version

* updated TableUpdate example

* changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example

* changed v1 to v2

* changed WorkspaceNameParameter back to V1

* added systemData

* removed systemData

* added systemData to Patch and Get

* moved systemData to Table properties

* deleted systemData from Table.json, added to Get and Put examles

* changed location of systemData in Tables.json

* moved systemData to inside Table definition

* moved systemData inside Table properties

* removed whitespaces

* changed DataExportErrorResponse to common
.../v2/types.json#/definitions/ErrorResponse

* changed all Error response of 2020-08 to common definition

* reference old versions of other apis (#13786)

* reference old versions of other apis

* remove old files

* Eiot sensors type alignment for new provider (#13780)

* change boolean to enum

* align new provider with new sensor field

* eiot-sensor-type-align

Co-authored-by: Gal Moshe <gamoshe@microsoft.com>

* Add SQL DB v5 SDK (#12107)

* add v5 sdk

* change recommendedAction.

* update a min sdk

* replace RecommendedAction defs with common type

* remove redundant defs in the 2014-04-01 legacy files.

* add RestorableDroppedDatabase json file.

* update RecommendedAction

* update update swagger to use 2020-11-01 preview spec

* revert int format change

* Dev weather microsoft.maps 1.0 (#13791)

* Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true

* Revert changes to package-lock.json

* [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-09-01 (#13505)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-07-15 to version 2020-09-01

* Updates readme

* Updates API version in new specs and examples

* New changes for 2020-09-01

* Prettier

Co-authored-by: Joshua McCarthy <jmccarthy@microsoft.com>

* Iot new device (#13503)

* new device model for iot swcurity

* spelling

* fixed lint error

* changed readme and added "x-ms-pageable" to device list

* moved the "x-ms-pageable" from get to list

* prettier

* PR comments

* Cplat sharedgallery2020 09 30 (#13655)

* [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2020-12-01-preview (#13609)

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* FixS360 | Microsoft.Billing (#13771)

* fixing billing accounts and operations

* adding total count.

* typo fix

* fixing spell check and prettier

* Vakuncha changingcsharpreadme (#13806)

* Update readme.csharp.md

* Update readme.csharp.md

* [aks] fix vm size model and osDiskType description  (#13763)

* fix: agent pool vm size should be string, not enum

* fix: osDiskType default description for >= 2020-11-01

* [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-03-01-preview (#13267)

* init

* fix format

* sync

* read only

* fix sample

* fix

Co-authored-by: Teng Pan <tepa@microsoft.com>

* storagesync readme t2 config (#13810)

* storagesync readme t2 config

* storagesync readme.python t2 config

* Updated SAS swagger with latest changes. (#13439)

* Fixed hostname in the Offazure swaggers.

* added newest swagger from service repo. This contains PE changes too.

* rewritten swagger changes on existing swagger

* some fixes to swagger

* added examples.

* fixes

* edit

* edit.

* fixes

* minor fix

* edit

* edit

* edited default api version tag

* Dev weather microsoft.maps 1.0 (#13796)

* Remove preview from Weather API, remove X-Publish, and convert X-ms-enum ModelAsString to true

* Revert changes to package-lock.json

* Fix spelling error

* Adding Azure Object Anchors error codes for IngestionProperties (#13787)

* Added Azure Object Anchors error code field to IngestionProperties

* Fixed spacing in example

* Moved changes to new version

* Addressed version mismatch, spacing

* Fixed versions on examples

* Readonly error code

* Seeing if readonly error code is breaking

* Revert "Seeing if readonly error code is breaking"

This reverts commit c0b16f07c4a46a07fc7831a1735bb290804242ea.

* Model error code as string

* Renamed examples to asset conversion nomenclature

* Fixed rename issues

* Fixed issue #9593 (#13262)

* Fixed issue #9593

* Removed redundant PrivateEndpointConnectionProperties attribute

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01 (#13800)

* Fixed Swagger Validation Errors

* Fixed Model Validation

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#13788)

* Fixed Swagger Validation Errors

* Fixed Type

* Fixed Type

* Fixed Setting Properties

* Fixed Punctuation

* Removed Item

* Added Items Properties

* Fixed Required Property

* azurestack wave4 t2 config (#13813)

* Added Microsoft.AppConfiguration 2021-03-01-preview API version. (#13490)

* Added Microsoft.AppConfiguration 2021-03-01-preview API version.

* Add system metadata to tracked resources in "Microsoft.AppConfiguration".
Updated ConfigurationStore to reference the common tracked resource type definition.

* Added disableLocalAuth property.

* Add new api version swagger to readme.

* Added/updated examples and added suppressions for standardized APIs.

* Fixed prettier.

* Add missing property fileStorageSkuName into MySQL Flexible Server spec (#13693)

* appplatform t2 readme config (#13829)

* customproviders t2 readme config (#13831)

* Update readme.csharp.md (#13807)

* [Sentine][Data connectors][Fix correctness bug] (#13175)

* update required fields

* update required fields

* Explicitly define KeyCreationTime in Feb21 (#13757)

* Explicitly define KeyCreationTime

Explicitly define KeyCreationTime

* Fix KeyCreationTime Example

Fix KeyCreationTime Example

* Add Microsoft.M365SecurityAndCompliance RP (#13646)

* Add Microsoft.M365SecurityAndCompliance RP

* fix datetime and common-types file path

* update common-types file path

* add preview path in readmego

* replace stable with preview

* remove duplicate tags

* refer MIPPolicySync json in readme

* service name for java (#13837)

* Dev keyvault microsoft.key vault 2021 04 01 preview (#13585)

* Adds base for updating Microsoft.KeyVault from version preview/2020-04-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Open API change for Managed Hsm private endpoints feature (#12938)

* Open API change for Managed Hsm private endpoints feature

* Fixing spell check errors

* Fixing spell check errors

* Prettier fixes

* Fixing swagger validation errors

* Fixing systemData property reference

* Adding publicNetworkAccess property based on private endpoint requirement.

* GET responses following a successful DELETE should be returning 404. … (#13054)

* GET responses following a successful DELETE should be returning 404. Only the DELETE response is to return 204 if the resource didn't exist (it allows idempotent deletes).

(cherry picked from commit b752a19c6cc1f8a8eed9f106e2c77b8d5b5db19f)

* Removing 404 as it is taken care by default response.

* Added new routes for Deleted ManagedHsm for Soft Delete Feature (#13282)

* Added new routes for Deleted ManagedHsm and examples, updated ManagedHsm definition to include PurgeDateTimeUTC

* Fixing validation issues.

* Fixing errors in properties in example jsons

* Delete keyvault.json

Deleted an errant json file

* Fixed misspelling of property in examples

* Fixed x-ms-examples naming, fixed camelcasing

* Addressing comments in PR to make 204s 404s and also changing PurgeDateTimeUTC to scheduledPurgeDate

* Added schema definitions for 404

* Removed 200 for purge

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Addressing Comments for PR 13585 (#13586)

* Removed 404s to allow requests to fall through to default

* Removing 404s from examples

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Added deletedmanagedhsm object to examples and managedhsm.json (#13591)

* Added deletedmanagedhsm object to examples and managedhsm.json

* Fixing error in references to correct values

* Changed vaultId to mhsmId in exmaples

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Try to use the common type for SystemData (#13723)

* Add SystemData property for KeyVault

* 04012021 fix schema (#13749)

* Resolving conflict with custom-words.txt

* Add 2021 preview to azureresourcechema, add suppression to readme

* Add 2021 preview to azureresourcechema

* Merging custom-words.txt

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Add missing default error response (#13762)

* Fix Lint error (#13765)

* Add missing default error response

* Update the integer format to fix Lint error

* Add securityDefinitions

* Added python tag for 2021 preview (#13805)

Co-authored-by: Soohwan Kim <sookim@microsoft.com>

* Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs (#13822)

* Fixing linting errors for MHSM R4036 - ImplementPrivateEndpointAPIs

(cherry picked from commit c1c5aebfb98cacd0a4ee5596fb7b0d9f782a9a3e)

* prettier fix

* Add suppression for SystemData (#13835)

* Add suppression for SystemData

* Fix linting error R4036 - ImplementPrivateEndpointAPIs

* specify the suppression for SystemData

* Revert "specify the suppression for SystemData"

This reverts commit cbebab81ab08ec1a29b41c891c58cf08ff2eb3c4.

Co-authored-by: jiacheng-L <71623842+jiacheng-L@users.noreply.github.com>
Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com>
Co-authored-by: Soohwan Kim <sookim@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>

* hybridnetwork only track2 configure (#13832)

* hybridnetwork only track2 configure

* remodify

* namespace del

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* terraform readme for alertsmanagement (#13744)

Co-authored-by: Your Name <you@example.com>

* add tags back in the adp readme (#13850)

* Add device principal type (#13799)

* copy files from previous version

* add device principal type, update versions

* fix

* system data requirement

* Added CheckNameAvailability, Identity, systemData, used ErrorResponse v2 in DeviceUpdate (#13750)

* Update deviceupdate.json

* Update deviceupdate.json

* Add files via upload

* Update deviceupdate.json

* Update deviceupdate.json

* Update Accounts_Update.json

* Update Accounts_Create.json

* Update Instances_Create.json

* Update deviceupdate.json

* Linux line ending

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update deviceupdate.json

* Update deviceupdate.json

* fixed typo in the example files (#13764)

* Update CODEOWNERS (#13795)

Updating list of Azure Cognitive Search team members

* Update GenerateDetailedCostReportBySubscriptionAndTimePeriod.json (#13772)

Update example data

* [Hub Generated] Public private branch 'stuartko/Mar21_NewTSVersion' (#13811)

* Adding version 2021-03-01-preview (copy of previous version)

* Adding new metadata property

* Adding uiDefinition property.

* Update uiDefinition name to uiFormDefinition (per a change by the service feature author). No change to functionality.

* Template Specs: Renaming template to "mainTemplate" and changing "artifacts" to be more specific "linkedTemplates".

* Swagger changes for 2021-02-01-preview api version (#13794)

* Copy existing preview version

* Changes to databoxedge json file

* Update readme files

* Correct Spell Check

* Fix Readme.go error

* Update examples

* Update all schemas.md files (#13862)

* typo: implmentation -> implementation (#13644)

* Add MongoDB/MongoDBAtlas sink (#13669)

* Add MongoDB/MongoDBAtlas sink, add disableMetricsCollection in read/wirte properties

* Revert disableMetricsCollection related changes

* Azure ML new API version 20210401 (#12981)

* Add Identity to createWorkpace example

* change for getTransitivePEUsages

* update

* prettier code

* add another new endpoint

* address comments

* change for getTransitivePEUsages

* update

* prettier code

* add another new endpoint

* address comments

* revert change on transitivePE and notebookKeys

* revert change on transitivePE and notebookKeys

* add new stable version 2021-01-01

* add ListNotebookAccessToken

* add primaryUserAssignedIdentity

* fix missing properties and apis

* fix one more missing property

* 202 status for start and stop CI

* make resync keys long runnin operation in version Jan2021

* resync keys 204

* update resync keys example

* Dont throw 204 for resync

* update resync keys

* Formatting

* revert Jan2021changes and add new version

* start apr2021 version for azure ml rp

* undo remove new line in jan2021

* use systemData definition in common

* removed old files

* fix small swagger bugs

* run prettier

* remove reference to sku

* update readme

* minimum agentCount should be 0

* add createdOn and ModifiedOn to compute properties

* add LoadBalancerType to aks compute

* add isNotebookInstanceCompute to virtualMachine

* add leafDomainLabel to SslConfiguration

* add overwriteExistingDomain to SslConfiguration

* add synapseSpark as supported compute-type

* update patch compute response to 202

* remove location from example responses

* Revert "remove location from example responses"

This reverts commit 048bf2551513afae842a9c4fbb5861aeddc6c33a.

* MachineLearningCompute_Update should have a 200 response

* sys data to use local def due to naming conflicts.

* Fix enum casing

* Fix operationId PR comment.

* Change opId in apr version

* remove 20210401 for easy review

* only change api version

* merge changes for 20210401 version

* Add x-ms-discriminator-value for Synapse spark

* camelcase loadbalancer properties

* add createdOn and Modified on to examples

* address AvoidAnonymousTypes error for SynapseSpark

* Minor fixes + new property

* Remove subscription state.

Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com>
Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com>
Co-authored-by: jopet@microsoft.com <jopet@microsoft.com>
Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com>

* datashare readme t2 config (#13833)

* add readme terraform (#13717)

* adding a new API version for Restore API and adding targetVirtualMachineId field for AzureWorkloadRestoreRequest (#13638)

* copying previous change

* Adding targetVirtualMachineId field for Azure Workload Restore requests

* updating crr version and examples

* removing new api-version

* adding back the new api-version

* removing Snapshot related fields

* updating readme.md

* corrected the path

Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com>

* chore: resort custom-words.txt from bad merge (#13868)

* [ApplicationInsights] Fix failure for python SDK (#13875)

* [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-10-05-preview (#13712)

* Adjustments to API to include validation grouping and updated text.

* Fixed missing curly brace

* adjusted name

* Added basic and standard examples

* adjusted type.

* corrected case for key value

* [Hub Generated] Review request for Microsoft.Insights to add version preview/2021-03-03-preview (#13269)

* Adds base for updating Microsoft.Insights from version preview/2020-10-05-preview to version 2021-03-03-preview

* Updates readme

* Updates API version in new specs and examples

* Add DiagnosticServiceToken API

* Update examples to split tokens for readonly vs readwrite

* Fix accoding to code review feedback

* Update examples due to review feedback from ARM

* add configuration for vmware (#13879)

Co-authored-by: Your Name <you@example.com>

* keyvault t2 config (#13863)

* keyvault t2 config

* keyvault multi-api config

* multi api config

* config reset

* add package version

* hanaonazure t2 readme config (#13880)

* Remove x-ms-azure-resource (#13500)

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

* Juniwang/sr202010401preview (#13664)

* prepare to add new api-version: copy everything from 2020-07-01-preview

* Adding new api-version

* Fix required body and annotate ms secrets

* remove secrets example from swagger

* fix prettier

* add datashare terraform configuration (#13876)

Co-authored-by: Your Name <you@example.com>

* storage readme t2 config (#13881)

* storage readme t2 config

* storage t2 config

* healthcareapis t2 config (#13884)

* typo: APIkeys -> APIKeys (#13641)

* Allow release_policy to be nullable (#13826)

* Fix type of Anserws and Captions (#13872)

* change the value of license header (#13886)

* [Synapse] - library_append API adds comp parameter (#13841)

* [Synapse] - add comp parameter

* Update example files

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

* Remove 200 response from async operation (#13190)

* Async operation always returns 202 on initial call

* Address review feedback

* Revert "Address review feedback"

This reverts commit 9ae550b95c1082c8383595a943a9abe5990fd4ef.

* add minimal tls version for mariadb (#11779)

* [Synapse] - add Swagger code owner (#13882)

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

* add con figuration for databoxedge (#13877)

Co-authored-by: Your Name <you@example.com>

* add configuration for resourcemover (#13878)

Co-authored-by: Your Name <you@example.com>

* Reduce code owner scope for Monitor.Exporters team (#13898)

* [portal]Update readme.python.md (#13907)

* Update readme.python.md

* Update readme.md

* Update readme.python.md

* Update readme.python.md

* Dev dfp microsoft.dfp 2021 02 01 privatepreview (#13305)

* New Readme Config File

* New Go Language Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New AzureResourceSchema Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* DFP API specs. Copied from Azure-PPE

* Spelling fix. instnace => instance

* Fix resource provider name to pascal case

* Added '/providers/Microsoft.Dfp/operations'

* Added SystemData (fix R4009 error)

* Fix validation errors

* Prettier fixes

* Removed non-existend parameter sku

* Style fixes in DFP API specs

* Swagger ModelValidation failures fix

* Fix operations API

* Fix operations API validation failure

* 1. Added example for lists operations. 2. made the API preview instead of privatepreview

* Fix path in readme's

* Fix in readme

* Added readonly attribute to systemdata

* Added readonly attribute to systemdata

* Fix in python SDK readme

* Fixes in ListOperations.json examples

* Fixed API version

* Added type to response bodies

* Fix typos in examples (urls)

* Added 201 response into createInstance example

* Renamed RP name from Microsoft.Dfp to Microsoft.Dynamics365Fraudprotection

* Added long-running result for creation instance

* Added nextlink

* Fix in checkNameAvailability definition URL

* Next link parameter

* Using references to common types instead of re-declaring them

* Reused common type. Fixed provisioning state

* Nesting error fix

* Fixed examples

* Fix

* Fix in error response definition

* Rename RP. Fix examples in readme's

* Added http 202

* Added http 202 to examples

* [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-10-01 (#13818)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-09-01 to version 2020-10-01

* Updates readme

* Updates API version in new specs and examples

* Adding new fields for 2020-10-01

* Updating wording for disablePasswordAuthentication'

Co-authored-by: jmccarthy <jmccarthy@microsoft.com>

* Remove name check from client side (#13492)

* remove name validation from client side

* remove name check from deploymentScripts swagger

* remove name check from previous swagger versions

* remove pattern from resourcegroupname parameter

* Update deviceupdate.json (#13900)

* [Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2018-07-01 (#13817)

* Updated api-version

* Removed systemData

* Updated api-version

* Updated the example

* Add EligibleChildResources resource for PIM + update examples (#13803)

* PIM API Specs

* update readme

* Update

* Update readme

* operation id fix

* name fix

* Name changes

* fix

* Fix

* Changes based on docs generated

* Scope fix in example

* Updates for documentation

* Change operation name

* Update examples

* Add expanded properties

* Fix formatting

* Fixes

* Fix

* fixes

* Update the policy specs

* Fix the policy objects and pell checks

* fix the checks

* fix the property

* fix syntax

* Prettier

* Update Examples

* Update Enums

* ADd eligible child resource API specs

* prettier fix

* Update read me files

* update

* update

* fix

* update

* Update Enums

* update

* update

* update

* update example

Co-authored-by: Aman Swaika <amansw@microsoft.com>
Co-authored-by: Gaurav Mishra (IDENTITY) <gamish@microsoft.com>

* refine readme.go.md (#13906)

Co-authored-by: Your Name <you@example.com>

* [Service Fabric Managed Clusters] adding api version 2020-05-01 (#13860)

* initial commit 2021-05-01 to compare with previous version 2021-01-01-preview

* update models

* update examples

* fix isStateless description

* add 2021-05-01 version to readme

* add x-ms-enum to diskType and add missing managedClsuterVersions paths

fix example names

add managed cluster version paths

add default error

* fix clusterversion by version and ClusterState descriptions

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

* Task 9639284: Swagger changes for new UK agreement templates (#13895)

* Task 9639284: Swagger changes for new UK agreement templates

* Renamed as per comments.

Co-authored-by: Umang Shah <umangshah@microsoft.com>

* Confluent new preview version + S360 fix (#13809)

* Adding new API version for Microsoft.Confluent

* Prettier fix

* updated status property in OfferDetail

updated status property in OfferDetail to fix swagger correctness issue

* fix swagger live validation

updated operations response to fix swagger live validation

Co-authored-by: Srinivas <alluri02@users.noreply.github.com>

* [Hub Generated] Public private branch 'juniwang/wps' (#13905)

* Onboarding Azure WebPubSub service

* reference ErrorResponse from common types and adding network ACL

* disable cors, enable feature flags and fix several policy violations

* remove anonymousConnectPolicy since it's not ready for now

* add property publicNetworkAccess per NRP requirement

* revert package-lock.json

* reset package-lock.json

* dns t2 readme config (#13923)

* update readme (#13918)

* add current readmes for generating python form recognizer (#12013)

* add current readmes for python form recognizer

* fix release tag

* updates for multiapi and preview.3

* fix so that gen code outputs in generated folder

* remove tag since swagger not in yet

* unbreak build

* just target preview 3

* don't run track 1 gen with python

* Set x-ms-api-version to false for vaults list (#13924)

* Set x-ms-api-version to false for vaults list (#13925)

* Update event description to include the event name (#13867)

* Update event description to include the event name

* Update readme to include guidelines for defining a new event

* Fix description

* Renamed enum values for SDK auto generation (#13938)

* Renamed enum values for SDK auto generation

* Tabs to spaces

* Newline added

* [Document Translator] update operation names (#13915)

* update operation names

* make body required

* Update ErrorName

* Apply changes to stable

* Fix samples

* fix sample

* Fix glossary sample

* Address comments and update definitions names

* Revert "Task 9639284: Swagger changes for new UK agreement templates (#13895)" (#13946)

This reverts commit ea5bc27ee9cadeb67767d774c82095be2420bcad.

* Adding new preview API for promotions (#11599)

* Adding new preview API for promotions

* Avacado fix

* Fixing JSON

* fixing the promo param

* fixning linting issues

* Fixing JSON

* fixing JSON

* fixing linting issues

* Adding delete 204a

* Adding delete 204

* Adding validation fixes

* fixing spellings

* Linting issues

* running prettier

* ARM review feedback

* Fixing linting issues

* Fixing prettier

* Fixing version

* Fixing SDK

* fixing go sdk

* revert go.md

Co-authored-by: Rishi Kapoor <rishik@microsoft.com>

* Exposing undocumented Databricks workspace properties for fixing S360 issues (#13683)

* exposing storage account name, sku

* Prettier fixes

* Fixing the review comment

* Adding No Public IP related properties

* Updating the remaining properties related to S360

* Fixing review comments

* Fixing Spell Check issue

* hybridcompute readme t2 config (#13910)

* readme t2 config

* hybridcompute t2 readme config

* web readme t2 config (#13909)

* web readme t2 config

* web readme.python t2 config

* Add x-ms-api-version (#13834)

* Update CheckNameAvailability_Available.json (#13914)

* webpubsub t2 config (#13949)

* Update StaticSite.json (#13768)

* Update StaticSite.json

Add private endpoint connections to static site object.

* Update StaticSites.json

* Update StaticSites.json

* Update StaticSites.json

* Update StaticSites.json

* increment readme version

* address PR comments

* add examples

* fix examples

* Add data-plane samples creation template (#13528)

* Add data-plane samples

* Simplified template

* webpubsub readme t1 del (#13953)

* Add $(multiapi) to QnA Maker's readme.md (#13819)

Generators were processing every tag when only a single one was desired. This is the common solution to support multi-api SDKs.

* IoT data-plane for drwill-ms (#13964)

* add missing usage.json to v5 sdk tag (#13960)

* [Hub Generated] Review request for Microsoft.Kusto to add version stable/2021-01-01 (#13306)

* Add new api version 2021

* remove managedIdentity since we won't support it in this version

* CR comments

* Add default value for contine on errros

* Fix swagger correctness issues

* Fix typo

* resource t2 readme config (#13974)

* Added new API and API version for private DNS zone suffix (#13789)

* Added new API and API version for private DNS zone suffix

* trigger validation pipelines

* Add new API to readme

* Fix ARM pipelines

* Try fix again

* Fix again

* Add Operations API

* Revert "Add Operations API"

This reverts commit 9d4ca9e557763feb3a6089ff9d4c958b3843730e.

* Revert "Revert "Add Operations API""

This reverts commit 7cf197c1d453764f0396713a2ab172a20e35b1c4.

* Revert "Revert "Revert "Add Operations API"""

This reverts commit 05744390e440984da8134b64a979a6e61fb9b7ae.

* Revert "Revert "Revert "Revert "Add Operations API""""

This reverts commit 61b76b1623d9e5796bb8187edf0fc46351e78231.

* Revert "Revert "Revert "Revert "Revert "Add Operations API"""""

This reverts commit 9f55eb4c399eb48a8578906f6bea43b10c91b8be.

* Address review comment from ARM

* Revert "Address review comment from ARM"

This reverts commit cb6d1b01860de72eec80856f64b602c72a1f26a7.

* Revert "Revert "Address review comment from ARM""

This reverts commit 227cf73797ee24a674d76e3ccd2990b84bc8d11a.

* Revert "Revert "Revert "Revert "Revert "Revert "Add Operations API""""""

This reverts commit 34ae6c70a514e0290ffb41f7ddb5bbbd5c6cbee3.

* Revert "Revert "Revert "Revert "Revert "Revert "Revert "Add Operations API"""""""

This reverts commit a11c889a65b0fa4257b03a247d75fbea769f4e2c.

* Add previous APIs to tag

* Retrigger build

* fix service name for Java (#13979)

* Add optional param - private DNS zone to server API (#13716)

* Add optional param - private DNS zone to server API

* Follow comment to resolve go sdk issue.

* [Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-04-01-preview (#13874)

* Adds base for updating Microsoft.Synapse from version stable/2021-03-01 to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* add changed files for kustoPool

* Ravi changes to fix LinDiff validation

* Add Itay Sofer's changes

* filizt comments mid-way

* Remove clouderror and resplace with "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"

* Add IotHubDataConnection and EventGridDataConnection

* Modify PUT to OK, CREATED, ACCEPTED

* Change from provisioningState to ResourceProvisioningState

* Add BlobStorageEventType

* Remove 202 when creating a KustoPool

* Change PUT/PATCH 202 responses

* Remove 202 in PATCH/PUT operations where having both 200 & 201

* Add "isIdentityCertExprired" to custom-words.txt

* Remove isIdentityCertExprired from custom-words.txt

* Add Exprired to cSpell.json

Co-authored-by: Amit Elran <amelran@microsoft.com>

* Removing x-ms-flatten property (#13929)

* manual changes for swagger

* changes for long-running operations

* changes for validate for backup and restore

* removing 204 from operationResults

* changes for a monitoring

* adding format

* removing date-time from duration

* changing to readonly

* changes for listRPs

* fixes swagger

* reverting readonly for scheduleTimes

* fixes for checkgates

* prettier fixes

* cahnges for friendlyname checks

* fixing gates

* removing tracking-via

* model validation fixes

* powershell changes

* adding stable version

* changes for PatchResourceRequestInput

* change for req fields

* changes for description

* changes

* Updated swagger json for item level restore target info objects

* Fixed spelling errors

* Added missing required properties

* removed auth credentials property

* prettier fixes

* Prettier fix

* pr comments fixes

* fixing readme

* changes for go readme

* Removed x-ms-flatten property (#2)

* removed flatten prop

* removing x-ms-flatten

* removing friendlyName from req prop

Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com>

Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com>
Co-authored-by: FAREAST\zakinkh <zakinkh@microsoft.com>

* confidentialledger readme t2 config (#13981)

* Additional 7.3-preview parameter name clean up (#13913)

* Enable multivariate anomaly detection (#13973)

* add multivarite

* add v1.1-preview

* reformat changepoint example

* change typo in readme

* fix prettier-check error

* add export model example

* fix prettier error

* [Azure Search] Add Knowledge Store feature to swagger (#13911)

* introduce knowledge store swagger

* add knowledge store to 2020 apis

Co-authored-by: Austin Drefke <jdrefke@microsoft.com>

* make skillset count optional, and add it to 2020 GA Swagger (#13990)

Co-authored-by: Austin Drefke <jdrefke@microsoft.com>

* Adding support for message properties in ACS Chat (#13939)

* Initial commit (copying over stable API version)

* Making changes to support message metadata

* Added 201 response code for patch operation (#13956)

Co-authored-by: Akash Keshari <akkeshar@microsoft.com>

* Adding autoMitigate flag with false as default value (#13109)

* deploymentmanager - clean up duplicate parameters outside of method (#13948)

* clean up duplicate parameters outside of method

* maintain python order

* fix typo in Synapse (#13994)

* OperationalInsights - update readme files for cli extension update (#13999)

* added3 new properties to TableProperties:
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.

* added Tables new api version

* changed bool to boolean types

* prettified jsons

* fix erroes in swagger

* undo changes to 2020-03-01-preview version

* pr fixes

* updated TableUpdate example

* changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example

* changed v1 to v2

* changed WorkspaceNameParameter back to V1

* changed ErrorResponse to default ErrorResponse without ref to local definition

* added systemData

* removed systemData

* added systemData to Patch and Get

* moved systemData to Table properties

* deleted systemData from Table.json, added to Get and Put examles

* changed location of systemData in Tables.json

* moved systemData to inside Table definition

* moved systemData inside Table properties

* removed SystemData

* creatted a new package containing all latest swagger files for publishing new SDK

* removed package 2021_02 and set default packate to 2020_10

* removed 2 packages

* removed DataCollectorLogs.json from readme.md 20202.10

* added empty line to try invoke pipeline validations that havent run

* Delete Tables.json

* added3 new properties to TableProperties:
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.

* merge

* prettified jsons

* undo changes to 2020-03-01-preview version

* updated TableUpdate example

* changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example

* changed v1 to v2

* changed WorkspaceNameParameter back to V1

* added systemData

* removed systemData

* added systemData to Patch and Get

* moved systemData to Table properties

* deleted systemData from Table.json, added to Get and Put examles

* changed location of systemData in Tables.json

* moved systemData to inside Table definition

* moved systemData inside Table properties

* removed whitespaces

* changed DataExportErrorResponse to common
.../v2/types.json#/definitions/ErrorResponse

* changed all Error response of 2020-08 to common definition

* added readme.az.md file for cli extension code generator

* added readme.ad.md with the same naming convention as in readme.python.md
added readme.cli.md file
updatted readme.md file with the new azure-cli-extensions tag
all updates were done by following: https://github.com/Azure/autorest.az/blob/9ed1aabd353385f8bdffbfa9f3892478111a029c/doc/how-to-author-readme-file.md

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* Update specification/operationalinsights/resource-manager/readme.az.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* added azure-powershell to readme.md

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>

* [Cognitive Services Metrics Advisor] add missing required for allOf entities (#13957)

* add missing required for allOf entities

* fix incorrect required properties

* 7.2-Preview to GA (#13919)

* 7.2-Preview to GA

* Update packages to point to stable

* Readd exportable and update description

* Update description for exportable in preview versions

* Fix operation results contract for Tenant Git operations (#13903)

* fix operation results contract

* fix sync state contract

* iothub t2 readme config (#13980)

* iothub t2 readme config

* iothub readme t2 config

* iothub t2 readme config

* Making Offer details and User Details required properties (#13985)

* Making Offer details and User Details required properties and removing abandoned tag

* fix python configuration

* Update readme.python.md

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* cosmosdb t1 config del (#14008)

* Fixing issue with missing filter documentation in Access Review APIs (#13892)

* fix cred issue. block to merge in DSMainDev (#14014)

* fix serivce name for java (#14007)

* maintenance readme t2 config (#13982)

* maintenance readme t2 config

* readme t1 config

* [Service Fabric Managed Clusters] fix api 2020_05_01 (#13961)

* Use enums  and add missing properties

* model enum as string

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

* [Hub Generated] Review request for Microsoft.BotService to add version stable/2021-03-01 (#13784)

* add isIsolated and channelSchemaTransformationVersion

* rename

* add v2 priavatelinks (#14026)

* copied from v1/privatelinks.json

* bump version

Co-authored-by: jianyexi <jianyxi@microsoft.com>

* APIM: improve developer portal operations docs (#13941)

* APIM: improve the documentation for dev portal operations

* Minor changes

* Removing OData parameters from the stable API version

* Remove new query params

* hotfix on extended location hierarchy (#13943)

* [Hub Generated] Public private branch 'wps' (#14002)

* Add webpubsub swagger

Add custom words

Update webpubsub.json

Update webpubsub.json

Resolve comments

Update webpubsub.json

resolve comments

Update operationId for existence check

[wps] update python generation section and client name for all languages (#1)

* add python stuff

* make title across languages the same

* Update version

* Update some constraints

* Update webpubsub.json

* rename to GetServiceStatus

* Update readme.md

* Update readme.md

* Update readme.md

* [Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2021-03-01-preview (#13563)

* Copied from 2019-01-01-preview version

* Updated references to common types

* Add itemsSearchKey field to Watchlists

* Add missing label definition

* Make itemsSearchKey as required field

* Formatting fixes

* Fix Prettier and Avocado errors

* Fix Lint error (subscription level resource)

* Update description and example for CreateOrUpdate watchlists and bulk create watchlist items

* Update Api version in examples

* [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-03-01 (#13888)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-01-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* updated default package in readme.md to 2021-03

Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com>

* Updated required and default fields in Action Groups spec (#13677)

* Updated error response for Action Groups API

* spacing

* added missing fields to Action Group Resource spec

* Added missing fields for action group resource in older version

* Updated "resource" name

* Removed changes to errorResponse

* Removed errorObject

* format

* Updated required and default fields in Action groups spec

* Update default value to boolean

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

* changes default value type to boolean

* undo webhook receiver changes

Co-authored-by: Ritwik Rajendra <rirajend@microsoft.com>
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

* Remove AML Compute File Server (#13944)

* Remove AML Compute File Server

* update

* update

* update

* update

* Cost Management: Reservation Recommendations API: Add multiple missing properties in specs (#13967)

* added totalCost, properties.resourceType, properties.subscriptionId, and eTag to various RiRec dfinitions

* moving eTag  property to right place

* remove duplicate description

* remove track1 configure (#14044)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* New API version (2021-02-10) for recovery services site recovery (#13525)

* Adding old API version(2018-07-10) to new folder for 2021-20-10

* all changes for swagger (2021-02-10)

* read me and custom word changes

* Ayesha's comments addressed

* adress PR comments from ayesha

* Adding suppressions

* fixing custom words

* [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-02-10 (#13636)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-02-01 to version 2021-02-10

* Updates readme

* Updates API version in new specs and examples

* Update readme.md

changing read me to include date too in tag

* cahnging examples API version to 2021-02-10

* fix read me syntax

* TaskStepProperties swagger fix (#13971)

* Adding "assignmentState" property to scope model in access review APIs (#14039)

* iothub readme.python package version change (#14043)

* iothub readme.python package version change

* multiapiscript add

* clear output folder

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* Bump y18n from 4.0.0 to 4.0.1 (#13704)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update (#14061)

* package-templatespecs-2021-03-preview tag added (python) (#13958)

* Added tag

* nit: ordering

Co-authored-by: Dania Etienne <daetienn@microsoft.com>

* Use 2014-04-01 replication link specs in V5 SDK (#14058)

* Use 2014-04-01 replication link specs in V5 SDK

* remove legacy file.

* Update cSpell.json for Key Vault 7.2 (storage) (#14060)

* automanage readme t1 del (#14029)

* automanage readme t1 del

* automanage readme t1 del

* readme.md t1 config del

* add missing reference (#13904)

* databoxedge readme modification (#14063)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* managedservices t2 onfig (#14064)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-02-10 (#13635)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-01-01 to version 2021-02-10

* Updates readme

* Updates API version in new specs and examples

* fixing merge issue

* removing vault usages from 2021-02

* Adding back vault usages

* updating readme

* updated etag to eTag (#13968)

* [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2020-12-01 (#13931)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2020-10-01 to version 2020-12-01

* Updates readme

* Updates API version in new specs and examples

* Adding new spot VM fields

Co-authored-by: Joshua McCarthy <jmccarthy@microsoft.com>

* Add FaceAPI PersonDirectory spec updates to preview v1.0 (#13766)

* Add FaceAPI v1.0-preview

Add a preview version of FaceAPI specs intended for public preview.
Contains existing spec in v1.0 plus PersonDirectory feature changes.

* Fixes after running validation

* Fixing validation

* Fixes 2

* Fixes 3

* Add PersonDirectory examples and fix routes

* Fixes 4

* Fixes 5

* Fixes 5.5

Co-authored-by: Yang Chen <yachen4@microsoft.com>

* Update the name and format of a parameter for randomnumbers (#14017)

* Update the name and format of a parameter for randomnumbers

* Change the parameter name from 'bytes_length' back to 'bytesLength'

* Amalladi/extendedlocation update (#13849)

* Updating Specification to remove 400 Badrequest from Swagger File

* Removing 400 status code from examples

* Removing private preview API version from Repo

* Removing 2020-07-15-privatepreview tag from ReadME files

Co-authored-by: Aditi <amalladi@microsoft.com>

* maps t2 config (#14075)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* Revert "remove track1 configure (#14044)" (#14047)

This reverts commit 867165cc24d81c487ad186c998c46ba55f81c77b.

* adding role assignment (#14077)

* add connectionPolicy spec back to V5 SDK (#14088)

* modification (#14087)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* [Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2021-04-01-preview (#13710)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-03-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json

* Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json

* Adding new API for fetching backup information(such as latest restorable timestmap) for a resource. Also, adding startTime,endTime to restorable.json

* adding Services APIs

* more changes

* updated examples

* prettier and readme updates

* importing changes missed from old versions

* nits

* fixing semantic validation

* fixing linter

* fix

* more fixes

* adding list operation and default error response

* specifying format integer

* attempt to fix sdks

* address arm comments and fix ci

* fixes

* fix

* try to fix ci

* fix examples

* .\services.json

* adding additionalProperties back to ServiceResouce

* adding additionalProperties back to ServiceResouce

* fix

* fix sdks

* fix linter

Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com>
Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>

* media t2 config(wave4) (#14074)

* media t2 config

* add packageversion

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* [Hub Generated] Review request for Microsoft.Maps to add version stable/2021-02-01 (#13733)

* Adds base for updating Microsoft.Maps from version preview/2020-02-01-preview to version 2020-02-01

* Updates for 2021-02-01 api version swagger

* creator swagger fixes

* fix model examples

* nextLink, uniqueId

* build fixes

* fixing listkeys

* fix long running operations

* fixing spelling

* fixing async behavior and examples

* updating arm region

* reset package-lock

* [Hub Generated] Review request for Microsoft.Media to add version preview/2021-05-01-preview (#13838)

* New Readme Config File

* New Go Language Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New AzureResourceSchema Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Copy Signed off 2021-03-01 swaggers here

* Update swaggers to 2021=05-01-preview

* add missing examples

* update title

* fix Operation id

* fix video analyzer examples

* update Video swagger

* add format for $top

* remove unnecessary example file

* use chackname definitions from types.json

* fix segment length readonly

* change getStreamingToken to listStreamingToken, getProvisioningToken to listProvisioningToken

* fix the example file name

* fix a readonly issue with a video property

* make type readonly

* edits to descriptions

* adding missing descriptions

* address review feedback,

* few cleanup for update class

Co-authored-by: Christopher Bennage <bennage@microsoft.com>

* Include the preview version of resource changes and resources history… (#14084)

* Include the preview version of resource changes and resources history APIs

* Address the review feedback on releasing the new package version.

* Update readme for Synapse management SDK May release (#14054)

* Update readme for Synapse management SDK May release

* Add package-2021-05-preview

* Address comment

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>

Co-authored-by: Denis Komissarov <73666576+dekomissMSFT@users.noreply.github.com>
Co-authored-by: rapatank <69176921+rapatank@users.noreply.github.com>
Co-authored-by: vnvaditya <vnvaditya@gmail.com>
Co-authored-by: Aditya Vutukuri <advutuku@microsoft.com>
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: abbhar <70494238+abbhar@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Zhou Liu <sumeng.liuz@gmail.com>
Co-authored-by: Nikhil Kumar Mengani <62704762+nimengan@users.noreply.github.com>
Co-authored-by: Melvin Bosnjak <meco0597@gmail.com>
Co-authored-by: Melvin Bosnjak <mbosnjak@microsoft.com>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: dabenhamMic <74346518+dabenhamMic@users.noreply.github.com>
Co-authored-by: jdhms <77470403+jdhms@users.noreply.github.com>
Co-authored-by: galmoshe <33285417+galmoshe@users.noreply.github.com>
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
Co-authored-by: Ji Wang <jiwang5@microsoft.com>
Co-authored-by: jsedlak-microsoft <65620804+jsedlak-microsoft@users.noreply.github.com>
Co-authored-by: Joshua McCarthy <joshdmccarthy@gmail.com>
Co-authored-by: Joshua McCarthy <jmccarthy@microsoft.com>
Co-authored-by: MichalHel <51286657+MichalHel@users.noreply.github.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: Mel M <50640763+melmullen@users.noreply.github.com>
Co-authored-by: Muaz Mian <muazmian@users.noreply.github.com>
Co-authored-by: varun kumar kunchakuri <66476965+vakuncha@users.noreply.github.com>
Co-authored-by: Ace Eldeib <alexeldeib@gmail.com>
Co-authored-by: tengpanpt <68668066+tengpanpt@users.noreply.github.com>
Co-authored-by: Teng Pan <tepa@microsoft.com>
Co-authored-by: kuchatur-ms <69152307+kuchatur-ms@users.noreply.github.com>
Co-authored-by: jastenze <71854693+jastenze@users.noreply.github.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Omar Rodriguez <73562205+omrodrig@users.noreply.github.com>
Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
Co-authored-by: Suna Liu <sunl@microsoft.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Yihang <hyhdtc@users.noreply.github.com>
Co-authored-by: sonalverm <73529783+sonalverm@users.noreply.github.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
Co-authored-by: Ritesh chitlangia <60164879+riteshchitlangia1@users.noreply.github.com>
Co-authored-by: jiacheng-L <71623842+jiacheng-L@users.noreply.github.com>
Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com>
Co-authored-by: Soohwan Kim <sookim@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Co-authored-by: zhangyan133 <77086185+zhangyan133@users.noreply.github.com>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
Co-authored-by: 陈箭飞 <32889038+chenjianfei2017@users.noreply.github.com>
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: Alexander Batishchev <abatishchev@gmail.com>
Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com>
Co-authored-by: Bruce Johnston <bruce.johnston@microsoft.com>
Co-authored-by: Abdullah Syed <50675866+absyed@users.noreply.github.com>
Co-authored-by: stuartko <47676853+stuartko@users.noreply.github.com>
Co-authored-by: pvsraviteja <67624658+pvsraviteja@users.noreply.github.com>
Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Guosen Wang <guoswang@microsoft.com>
Co-authored-by: Suba <sk.suba1@gmail.com>
Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com>
Co-authored-by: Vinay Rajmal Soni <vison@microsoft.com>
Co-authored-by: jopet@microsoft.com <jopet@microsoft.com>
Co-authored-by: Josh Peterson <15050193+joshanator@users.noreply.github.com>
Co-authored-by: chandrikagonuguntla <chandrikagonuguntla@users.noreply.github.com>
Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com>
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Co-authored-by: aarongas <aarongas@microsoft.com>
Co-authored-by: Saar Shen <saars@microsoft.com>
Co-authored-by: Dongwei Wang <bean0idear@163.com>
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Co-authored-by: Junbo Wang <juniwang@microsoft.com>
Co-authored-by: Hervey Wilson <herveyw@microsoft.com>
Co-authored-by: Janusz Lembicz <jlembicz@microsoft.com>
Co-authored-by: Arcturus <dapzhang@microsoft.com>
Co-authored-by: Alexander Schmidt <aschmidt@microsoft.com>
Co-authored-by: ThomasDai <73230321+ThomasDai@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: alexsavo-ms <78455310+alexsavo-ms@users.noreply.github.com>
Co-authored-by: TJ Egbejimba <toegbeji@microsoft.com>
Co-authored-by: averyrob <78236769+averyrob@users.noreply.github.com>
Co-authored-by: Aman Swaika <aman.swaika@gmail.com>
Co-authored-by: Aman Swaika <amansw@microsoft.com>
Co-authored-by: Gaurav Mishra (IDENTITY) <gamish@microsoft.com>
Co-authored-by: Alfredo Santamaria <chino.sebastian@gmail.com>
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Co-authored-by: us6193 <umangshah6193@gmail.com>
Co-authored-by: Umang Shah <umangshah@microsoft.com>
Co-authored-by: Krishna Sri Somepalli <krsomepa@microsoft.com>
Co-authored-by: Srinivas <alluri02@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com>
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Co-authored-by: rkapso <rishi.kaps@gmail.com>
Co-authored-by: Rishi Kapoor <rishik@microsoft.com>
Co-authored-by: Subrahmanyam Mandavilli <subraman@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: mkarmark <mikarmar@microsoft.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: docohe <54349195+docohe@users.noreply.github.com>
Co-authored-by: taogems <55105930+taogems@users.noreply.github.com>
Co-authored-by: Amit Elran <amitelran2110@gmail.com>
Co-authored-by: Amit Elran <amelran@microsoft.com>
Co-authored-by: Mayank Aggarwal <mayankagg9722@gmail.com>
Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com>
Co-authored-by: FAREAST\zakinkh <zakinkh@microsoft.com>
Co-authored-by: Congrui <43364740+conhua@users.noreply.github.com>
Co-authored-by: jadrefke <jadrefke@gmail.com>
Co-authored-by: Austin Drefke <jdrefke@microsoft.com>
Co-authored-by: Amr Elroumy (Work) <77645021+amrelroumy-msft@users.noreply.github.com>
Co-authored-by: akashkeshari <akashkeshari3010@gmail.com>
Co-authored-by: Akash Keshari <akkeshar@microsoft.com>
Co-authored-by: simanor <49607823+simanor@users.noreply.github.com>
Co-authored-by: Tom FitzMacken <tomfitz@microsoft.com>
Co-authored-by: bowgong <56386108+bowgong@users.noreply.github.com>
Co-authored-by: Jack Lichwa <52512203+jlichwa@users.noreply.github.com>
Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: jainharsh98 <jainharsh.098@gmail.com>
Co-authored-by: Shubham Gupta <shugup@microsoft.com>
Co-authored-by: ssss141414 <shzhen@microsoft.com>
Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: jianyexi <jianyxi@microsoft.com>
Co-authored-by: Mike Budzynski <40186513+mikebudzynski@users.noreply.github.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
Co-authored-by: mayank88mahajan <mayank88mahajan@gmail.com>
Co-authored-by: Ritwik Rajendra <21337621+ritwik8119@users.noreply.github.com>
Co-authored-by: Ritwik Rajendra <rirajend@microsoft.com>
Co-authored-by: Weiguo Zhang <wzhang@microsoft.com>
Co-authored-by: maddieminn <79888413+maddieminn@users.noreply.github.com>
Co-authored-by: nilgupta6 <78136736+nilgupta6@users.noreply.github.com>
Co-authored-by: Yuan Xi <y25xi@uwaterloo.ca>
Co-authored-by: Kai-Wen Feng <82062838+kaiwenfeng4086@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yuping Wei <56525716+yupwei68@users.noreply.github.com>
Co-authored-by: Dania Etienne <etienne.dania@gmail.com>
Co-authored-by: Dania Etienne <daetienn@microsoft.com>
Co-authored-by: msyache <70287970+msyache@users.noreply.github.com>
Co-authored-by: Yang Chen <yachen4@microsoft.com>
Co-authored-by: yl-ms <79939366+yl-ms@users.noreply.github.com>
Co-authored-by: Aditi <12823918+aditimalladi@users.noreply.github.com>
Co-authored-by: Aditi <amalladi@microsoft.com>
Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com>
Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com>
Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>
Co-authored-by: Daniel Stack <dstack@microsoft.com>
Co-authored-by: giakas <giakas@microsoft.com>
Co-au…
…k profile (#13449)

* Add network interface configuration schema for virtual machine network profile

* PR comments

* fix lint errors

* PR comments

* comments and fixes

* move DeleteOption from VirtualMachineScaleSetIPConfigurationProperties to VirtualMachineScaleSetPublicIPAddressConfiguration

* fix build checks

* fix VirtualMachineNetworkInterfaceConfiguration definition

* fix networking api version

* Add example

* link example file

* fix example

Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
#13468)

* Add OSProfile.WindowsConfiguration.PatchSettings.assessmentMode + LinuxConfiguration.PatchSettings.AssessmentMode + examples

* Fixes from checkers

* Update assessmentMode.Manual to ImageDefault

* Add missing enum values to the UpgradeState enum

* Reorder properties per comment

* Reverting breaking change
@Sandido Sandido added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 26, 2021
roipmsft and others added 3 commits April 26, 2021 14:58
* added

* remove hello

* add userData to VM properties and VMSS vm profile

* update enums

* update $expand;

* update

* add json files

* reference the json files

* update examples

* addressing comments from PR

* document min api versions

* revert changes to 2020 12 1

* remove two files

* undo changes to computejosn

* fix json

* try fix descrition

* revert descrition

* addressing comments from PR

* addressing comments from PR

* change modelAsString to false

* update json

* remove userdata from enum

* add UserData to enum

* update userdata enum for breaking change intentionally

* rename enum names

* update

* use modelAsString false

* updated desc

* add UserData for InstanceViewTypes enum

* udpate api versin

* add userData to 2020-08-02/HybridCompute.json

* add userData to cloudService.json

* update

* add userdata to get vm example

* add two new example jsons

* update examples

* prettier fix

* modify examples

* remove userData

* remove userData from cloudService

* explain userData in comments

* addressing comments from PR

* resolve conflict

* update comment

* update
* add endpoints

* remove x-ms-azure-resource from proxy only resource

* update customWords.txt

* added example jsons

* remove the example

* remove exampolels

* add comma

* fix  rp creation comment

* reove oprtional properties

* delete duplicate rp properties

* add RestorePointCreate

* add x-ms-azure-resource to proxy resource

* added suppressions

* add json and supressions

* try simpler json

* update restore opint

* fixcomments

* minor fixes

* save with prettier

* add example for create rpc

* update example jsons

* udpate rpc json

* udpate rpc json again

* make location required

* update rpc again

* suppress NestedResourcesMustHaveListOperation

* update readme

* addressing comments from PR

* update

* addressing comments from PR

* use modelas string true

* description

* add default error back

* add examples for PIR team, as requested by Yemi Oyebode

* add security profile to rpSourceMetaData

* add provisioning state to RPC

* replace links

* update links

* udpate examples/CreateARestorePoint.json

* add examples/GetRestorePointCollection.json

* update

* fix rpc name

* addressing comments from PR

* add location and rpcId to swagger

* fix example jsons

* update

* add example jsons

* fix model validation

* tentative fix for sub resource

* tentative fix

* add nested properties

* dont use flatten

* remove properites

* use all of

* try removing location

* remove location required atribute

* ad type object

* update

* use rpc source object

* move allOf to same level as properties

* drop subResource prop from sourceCollectionProeprties

* sabe

* add location to update rpc.json

* fix examples.json. fix OS type enum

* fix invalid json

* correct readonly fields

* update examples

* addressing comments from PR

* add comment

* fix prettiercheck

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
@Sandido
Copy link
Member Author

Sandido commented Apr 26, 2021

The .Net SDK PR check error was introduced by this PR: https://github.com/Azure/azure-rest-api-specs/pull/14095/files
It is not related to my changes in this PR.

@Sandido
Copy link
Member Author

Sandido commented Apr 26, 2021

The breaking change compared to the 2016 version is not a valid failure as the changes were introduced long ago and not in this version.
The breaking change compared to the 2012 version (the enum constraint weakening) was approved in this PR: #13220

@Sandido
Copy link
Member Author

Sandido commented Apr 26, 2021

The APIDocPreview error is expected.
The error can be resolved after this swagger version releases and I update https://github.com/Azure/azure-docs-rest-apis/blob/a3471166348cdcb19ecff2bba982523939796784/mapping.json#L1156

This also occurred in the 2012-12-01 release and the Doc team advised this post-release fix.

@Sandido
Copy link
Member Author

Sandido commented Apr 26, 2021

The ARM team also reviewed the 2 PRs in this release that need ARM signoff.

@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 27, 2021
Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each PR Is reviewed seperated in compute feature branch

@yungezz yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 28, 2021
@chiragg4u
Copy link
Contributor

Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.

@Sandido
Copy link
Member Author

Sandido commented Apr 29, 2021

@chiragg4u , apologies for not having that setup.
The Commits that were used to setup the branch for the new version are:

d5b2146
e45d32a
840f44e
134aa58
29a5ff6

The changes merged with new features for this release are listed in the initial PR comment as separate PRs.

@chiragg4u
Copy link
Contributor

If you want to get faster review please follow the recommended pattern. I won't be able to review this PR in current form, sorry!


In reply to: 829242309

Copy link
Contributor

@chiragg4u chiragg4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@Sandido Sandido mentioned this pull request May 3, 2021
26 tasks
@Sandido Sandido closed this May 5, 2021
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

2 similar comments
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @Sandido. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn JackTn deleted the compute-2021-03 branch July 5, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-BreakingChange-Go CI-BreakingChange-Python WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.